This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Gluon] Support None argument in HybridBlock #16280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
changed the title
[Gluon] Support None as the argument for HybridBlock
[Gluon] Support None argument in HybridBlock
Sep 26, 2019
wkcn
reviewed
Sep 26, 2019
wkcn
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! LGTM : )
support None as arguments in HybridBlock Update block.py fix fix Update test_gluon.py Update test_gluon.py
sxjscience
force-pushed
the
support_none_hybrid_block
branch
from
September 26, 2019 01:09
5be5840
to
60708d7
Compare
leezu
approved these changes
Sep 26, 2019
haojin2
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eric-haibin-lin FYI on the merge. |
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* support none in hybridblock argument support None as arguments in HybridBlock Update block.py fix fix Update test_gluon.py Update test_gluon.py * fix bug * fix bug * test case of default values
sojiadeshina
pushed a commit
to sojiadeshina/incubator-mxnet
that referenced
this pull request
Sep 30, 2019
* support none in hybridblock argument support None as arguments in HybridBlock Update block.py fix fix Update test_gluon.py Update test_gluon.py * fix bug * fix bug * test case of default values
Merged
4 tasks
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #13247
We will later consider to support dict, OrderedDict, namedtuple and customized python classes in Gluon 2.0 @leezu @junrushao1994
Support the following way of writing the hybrid_forward:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes